Make And expression JSON serializable using Pydantic#2560
Make And expression JSON serializable using Pydantic#2560Aniketsy wants to merge 7 commits intoapache:mainfrom
Conversation
|
@Fokko Could you please review these changes when you have time. |
|
@Aniketsy Thanks for working on this, but I think this one is problematic, since it relies on |
|
@Fokko sure, I will wait till |
|
@Fokko I think PR on |
|
@Aniketsy Certainly, let me know if you run into anything 👍 |
|
I would recommend taking some inspiration from the |
|
@Aniketsy gentle ping on this :) |
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
d0284b5 to
dd534a8
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
6607718 to
59674ec
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
55e54cf to
536e2b8
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
e4b84dc to
6f71f21
Compare
|
@kevinjqliu Could you please take a look and help me understand why one of the tests is failing? |
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
bb716a8 to
321c5b6
Compare
|
@Aniketsy Gentle ping! |
|
Closing this in favor of #2784 |
3 participants
#2518
This PR addresses issue by making the
Andexpression in pyiceberg.expressions fully JSON serializable using Pydantic.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thank you !